search

regl-project / regl

👑 Functional WebGL
MIT License
5.19k stars 320 forks source link

http://regl.party/API code example error #428

Open Javingka opened 6 years ago

Javingka commented 6 years ago

I'm not sure if this is the place to publish the issue, but I didn't find a better place.

It seems there is an error at http://regl.party/api#inputs code example:

    angle: function (context, props, batchId) {
      return args.speed * context.tick + 0.01 * batchId
    },

The code is using args instead of props, the return statement should be:

      return props.speed * context.tick + 0.01 * batchId
arscan commented 6 years ago

I believe that this was addressed in PR https://github.com/regl-project/regl/pull/357 but it hasn't been deployed.

gregtatum commented 6 years ago

I'm tracking website deployment here: #445