regner / albiondata-client

Distributed client for the Albion Data project.
https://albion-data.com/
MIT License
38 stars 17 forks source link

Marshalling, error handling, logging of "sending" should be refactored in a common function #130

Closed oxisto closed 7 years ago

oxisto commented 7 years ago

As i'm trying to write my second event/operation handler and looking at others, I noticed that basically the last 5-10 lines of each operation are copy-paste and could be refactored in a common function which does the following:

oxisto commented 7 years ago

For private exports it should also check if albionState.CharacterId and/or albionState.CharacterName are already there, otherwise skip the ingest.

Ideally it should even populate these values in the Upload object

regner commented 7 years ago

Agreed, this would be a wonderful thing to have.

oxisto commented 7 years ago

If you want, you can assign this issue to me and I'll look into it.

jochumdev commented 7 years ago

Its merged.