search

regner / albiondata-client

Distributed client for the Albion Data project.
https://albion-data.com/
MIT License
38 stars 17 forks source link

windows desktop notifications, darwin + nix notifications. #138

Closed Ultraporing closed 7 years ago

Ultraporing commented 7 years ago

Adresses issue #134

regner commented 7 years ago

Just one minor comment.

Ultraporing commented 7 years ago

done

oxisto commented 7 years ago

Could you please see, if you can also include a notification here: https://github.com/Regner/albiondata-client/blob/d9c4c9fd4c648ab86178441a1ef2d6b3b417dfac/client/dispatcher.go#L69

Thanks!

Ultraporing commented 7 years ago

give me a few sec, we probably should rewrite the logger. With the ability to additionally push the message as notification. I'll start on that in another branch once this on is pulled, since its alot of changes.

regner commented 7 years ago

Will we ever change the "title" parameter? Seems we should just hard code that to "Albion Data Client" for now until we have a need to change that instead of passing the same thing every time.

Ultraporing commented 7 years ago

done

regner commented 7 years ago

Thanks once again @Ultraporing!