regolith-labs / ore-cli

Command line interface for ORE cryptocurrency mining.
919 stars 443 forks source link

support for base58 private key #39

Closed GoudanWoo closed 3 months ago

GoudanWoo commented 3 months ago

--private-key <base58 privkey>

tonton-sol commented 3 months ago

Continually passing your private key as a CLI argument is NOT recommended! Create a keypair using solana-keygen recover and pass it your mnemonic phrase.

GoudanWoo commented 3 months ago

I understand that private key security needs to be considered. But I think that's something users need to consider, not dev.

tonton-sol commented 3 months ago

Understood, but the standard for solana CLI tooling is to pass keypairs. I think the Dev should ultimately be concerned about end-user security.

GoudanWoo commented 3 months ago

ok i know it.