search

regolith-linux / regolith-compositor-picom-glx

GLX backend Picom configuration for Regolith
2 stars 3 forks source link

Fix chrome shadow #11

Open kgilmer opened 5 months ago

kgilmer commented 5 months ago

Exploratory changes based on discussion https://github.com/orgs/regolith-linux/discussions/949#discussioncomment-8939675. Awaiting user feedback.

Filip-K commented 5 months ago

Hi @kgilmer! Thanks for taking this up. The exact change that fixes the issue for me is menu = { shadow = false; }. I've been running it since December without any additional* issues, and it seems to have helped many other people too. So I think this change is generally useful and could be merged.

Now, there are a few other changes in this PR besides menu = { shadow = false; }, for dock and tooltip window types. I'm not sure where these come from and I cannot vouch for them, but if you're confident about them I see no issue with merging this PR as is. I've introduced these extra changes into my picom config just now and I don't see any effect immediately.

(*) I'm saying 'additional' issues because, unfortunately, I see a number of other issues with picom shadows that are unaffected by this change, and so outside the scope of this PR. For example, the main chrome window loses its shadow when displaying certain websites (e.g. GH issues, but not GH discussions 🤯).