regolith-linux / regolith-desktop

Meta package for the Regolith Desktop Environment
1.5k stars 31 forks source link

Add arc-theme in regolith-look #267

Open akss13 opened 4 years ago

akss13 commented 4 years ago

https://github.com/horst3180/arc-theme

kgilmer commented 4 years ago

How to: https://regolith-linux.org/docs/developer/looks/

JoshuaCrewe commented 4 years ago

I’d be interested in this too. Has anyone made a start on it? I’ll get to reading up on how it would be done. If anyone has a starting point already we can work from that!

JoshuaCrewe commented 4 years ago

There is already a bit of a leg up in the sense that these theme configs probably already exist on the internet. Arc is itself a GTK theme and there is already an official Rofi theme. Whats missing? The i3 bar?

In the nord root file there are references to other config files :

! -- Applications
! These files map values defined above into specific app settings.
#include "/etc/regolith/styles/st-term"
#include "/etc/regolith/styles/i3-wm"
#include "/etc/regolith/styles/i3xrocks"
#include "/etc/regolith/styles/rofi"
#include "/etc/regolith/styles/gnome"

If I am understanding that comment correctly we fill out color, typeface and theme and we get styles for those apps for free?

kgilmer commented 4 years ago

@JoshuaCrewe yes that's correct. The readme here gives more detail as to how the various styles files relate. Good luck and we're always happy to answer questions, either here or in slack.

JoshuaCrewe commented 4 years ago

Brilliant! I made a start on this and have a repo ~I need to publish. I’ll do that and link it if anyone wants to join in. But for the moment work has taken over all my mental budget :)~ which can be found here

Anyone is free to join in 👍

JoshuaCrewe commented 4 years ago

@kgilmer I have started trying to map the colours from the arc theme to a regolith look template and it is a bit trial and error. Which is fine. I can make it better by spending less time in a VM and get a proper dev environment setup.

My question is that there already exists Arc themes for various bits and bobs. The rofi one I already incorporated. Should I be including the Arc GTK theme in somehow? That would make the Files app look the part right? (sorry I am a bit new to this side of things). Is there any guidance on what the variables in colors is used for, specifically base1-3 and base01-03 ?

kgilmer commented 4 years ago

Hi @JoshuaCrewe !

Should I be including the Arc GTK theme in somehow?

Yes, you would specify the GTK theme with the gtk_theme define, which would then get loaded here: https://github.com/regolith-linux/regolith-styles/blob/master/Xresources/gnome#L1-L2

That would make the Files app look the part right?

I believe so, yes.

Is there any guidance on what the variables in colors is used for, specifically base1-3 and base01-03 ?

The existing color names are based on the original theme: Solarized. You can see how they are referring to bases here: https://ethanschoonover.com/solarized/

Sorry, there isn't a clean schema for the color designations. We have considered migrating to base16 but it's a lot of work, so things remain as they are for the time being.

lbibass commented 3 years ago

Is there an update to this? Would love to have this theme in Regolith.

kgilmer commented 3 years ago

The blocker at this point is producing a valid debian package for the Ark GTK theme. Due to some symlink build stuff, proper packaging has been difficult. There are a few open source GTK themes with clean, sane builds, such as the pop-os GTK theme, but I haven't had time yet to look into using for an Arc gtk theme.