regolith-linux / regolith-desktop

Meta package for the Regolith Desktop Environment
1.48k stars 31 forks source link

Regolith 3 Beta 1: Keybindings don't migrate #866

Closed alexschneider closed 1 year ago

alexschneider commented 1 year ago

Describe the bug I had several custom settings/keybindings in ~/.config/regolith2/i3/config.d/keybindings for use in Regolith 2, but when I migrated to Regolith 3 the keybindings don't seem to be sticking. I've tried moving it to ~/.config/regolith3/i3/config.d, ~/.config/regolith3/sway/config.d,~/.config/regolith3/common/config.d, and none of them seem to work.

To Reproduce

Here's a selection of configuration I've made:

bindsym $mod+x move workspace to output next
bindsym Print exec --no-startup-id flameshot gui
bindsym $mod+Shift+s sticky toggle
bindsym $mod+Shift+f floating toggle; [floating] resize set 1200 900 ; move position center
for_window [title="^Live Caption"] floating enable sticky enable border pixel 0
for_window [class="slack"] sticky enable
for_window [title="^zoom$"] floating enable

Expected behavior The configuration takes effect

Installation Details

alexschneider commented 1 year ago

I figured it out, the magic folder is ~/.config/regolith3/wm/config.d but leaving this as a bug since it should be in the documentation.

SoumyaRanjanPatnaik commented 1 year ago

Definitely a bug. The directory should be regolith3/i3/config.d.

ferdinandyb commented 1 year ago

Definitely a bug. The directory should be regolith3/i3/config.d.

Yeah, the regolith3/wm/config.d was the correct folder before the recent update, but now it is i3 again. Why is this not the same folder for i3 and sway?

SoumyaRanjanPatnaik commented 1 year ago

Definitely a bug. The directory should be regolith3/i3/config.d.

Yeah, the regolith3/wm/config.d was the correct folder before the recent update, but now it is i3 again. Why is this not the same folder for i3 and sway?

Sway configurations are typically a superset of i3 configs. And in some cases, the same configs may lead to different behaviours. So it makes sense to have them separate. The latest update did however add a common-wm directory for common configs.

ferdinandyb commented 1 year ago

On Thu Jul 06, 2023 at 22:37, Soumya Ranjan Patnaik wrote:

Definitely a bug. The directory should be regolith3/i3/config.d.

Yeah, the regolith3/wm/config.d was the correct folder before the recent update, but now it is i3 again. Why is this not the same folder for i3 and sway?

Sway configurations are typically a superset of i3 configs. And in some cases, the same configs may cause. So it makes sense to have them separate. The latest update did however add a common-wm directory for common configs.

nice, thanks for the info!

kgilmer commented 1 year ago

I believe this issue is addressed, kindly re-open if I missed something