common 30_navigation config file throws errors after upgrade from 3.0 to 3.1

IanEdington commented 6 months ago

[x] I've run a search on the existing bug reports to make sure I'm not filing a duplicate (you can use the search box at the top left corner)
[x] I've read the Regolith documentation and didn't find any relevant topic
[ ] I tried asking on Slack (especially for configuration related issues)
- doesn't work ^ Seems like a bug is the right place to put this rather than a discussion, but I can post it there instead if you'd like me to

Describe the bug When I upgraded to 3.1 the common nav config broke. Even when I remove my own config files! /usr/share/regolith/common/config.d/30_navigation

To Reproduce upgrade from 3.0 to 3.1

Expected behavior configuration files to be working after the upgrade

Configuration file(s) none. This error occurs without any config files in ~/.config/regolith

Installation Details

Regolith Install Type: PPA
Regolith Version: 3.1
PPA url: https://regolith-desktop.org/release-3_1-ubuntu-jammy-amd64
Host OS (for PPA): Ubuntu 22.04

Additional context

Full Error Message:

ERROR: CONFIG: Expected one of these tokens: '--release', '--border', '--whole-window', '--exclude-titlebar', 'Mod1', 'Mod2', 'Mod3', 'Mod4', 'Mod5', 'Shift', 'Control', 'Ctrl', 'Mode_switch', 'Group1', 'Group2', 'Group3', 'Group4', '$mod', '+', <wor
d>
ERROR: CONFIG: (in file /usr/share/regolith/common/config.d/30_navigation)
ERROR: CONFIG: Line  51: ## Navigate // Next Workspace // <> Tab ##
ERROR: CONFIG: Line  52: set_from_resource "" wm.binding.ws_next Tab
ERROR: CONFIG: Line  53: bindsym Mod4+"" workspace next
ERROR: CONFIG:                         ^^^^^^^^^^^^^^^^
ERROR: CONFIG: Line  54: 
ERROR: CONFIG: Line  55: ## Navigate // Next Workspace // <><Alt> → ##
ERROR: CONFIG: Expected one of these tokens: '--release', '--border', '--whole-window', '--exclude-titlebar', 'Mod1', 'Mod2', 'Mod3', 'Mod4', 'Mod5', 'Shift', 'Control', 'Ctrl', 'Mode_switch', 'Group1', 'Group2', 'Group3', 'Group4', '$mod', '+', <wor
d>
ERROR: CONFIG: (in file /usr/share/regolith/common/config.d/30_navigation)
ERROR: CONFIG: Line  55: ## Navigate // Next Workspace // <><Alt> → ##
ERROR: CONFIG: Line  56: set_from_resource "" wm.binding.ws_next2 Right
ERROR: CONFIG: Line  57: bindsym Mod4+Mod1+"" workspace next
ERROR: CONFIG:                              ^^^^^^^^^^^^^^^^
ERROR: CONFIG: Line  58: 
ERROR: CONFIG: Line  59: ## Navigate // Next Workspace on Output // <><Ctrl> Tab ##
ERROR: CONFIG: Expected one of these tokens: '--release', '--border', '--whole-window', '--exclude-titlebar', 'Mod1', 'Mod2', 'Mod3', 'Mod4', 'Mod5', 'Shift', 'Control', 'Ctrl', 'Mode_switch', 'Group1', 'Group2', 'Group3', 'Group4', '$mod', '+', <word>
ERROR: CONFIG: (in file /usr/share/regolith/common/config.d/30_navigation)
ERROR: CONFIG: Line  59: ## Navigate // Next Workspace on Output // <><Ctrl> Tab ##
ERROR: CONFIG: Line  60: set_from_resource "" wm.binding.ws_next_on_output Ctrl+Tab
ERROR: CONFIG: Line  61: bindsym Mod4+"" workspace next_on_output
ERROR: CONFIG:                         ^^^^^^^^^^^^^^^^^^^^^^^^^^
ERROR: CONFIG: Line  62: 
ERROR: CONFIG: Line  63: ## Navigate // Next Workspace on Output // <><Ctrl> l ##
ERROR: CONFIG: Expected one of these tokens: '--release', '--border', '--whole-window', '--exclude-titlebar', 'Mod1', 'Mod2', 'Mod3', 'Mod4', 'Mod5', 'Shift', 'Control', 'Ctrl', 'Mode_switch', 'Group1', 'Group2', 'Group3', 'Group4', '$mod', '+', <word>
ERROR: CONFIG: (in file /usr/share/regolith/common/config.d/30_navigation)
ERROR: CONFIG: Line  63: ## Navigate // Next Workspace on Output // <><Ctrl> l ##
ERROR: CONFIG: Line  64: set_from_resource "" wm.binding.ws_next_on_output2 Ctrl+l
ERROR: CONFIG: Line  65: bindsym Mod4+"" workspace next_on_output
ERROR: CONFIG:                         ^^^^^^^^^^^^^^^^^^^^^^^^^^
ERROR: CONFIG: Line  66: 
ERROR: CONFIG: Line  67: ## Navigate // Previous Workspace // <><Shift> Tab ##
ERROR: CONFIG: Expected one of these tokens: '--release', '--border', '--whole-window', '--exclude-titlebar', 'Mod1', 'Mod2', 'Mod3', 'Mod4', 'Mod5', 'Shift', 'Control', 'Ctrl', 'Mode_switch', 'Group1', 'Group2', 'Group3', 'Group4', '$mod', '+', <word>
ERROR: CONFIG: (in file /usr/share/regolith/common/config.d/30_navigation)
ERROR: CONFIG: Line  67: ## Navigate // Previous Workspace // <><Shift> Tab ##
ERROR: CONFIG: Line  68: set_from_resource "" wm.binding.ws_prev Shift+Tab
ERROR: CONFIG: Line  69: bindsym Mod4+"" workspace prev
ERROR: CONFIG:                         ^^^^^^^^^^^^^^^^
ERROR: CONFIG: Line  70: 
ERROR: CONFIG: Line  71: ## Navigate // Previous Workspace // <><Alt> ← ##
ERROR: CONFIG: Expected one of these tokens: '--release', '--border', '--whole-window', '--exclude-titlebar', 'Mod1', 'Mod2', 'Mod3', 'Mod4', 'Mod5', 'Shift', 'Control', 'Ctrl', 'Mode_switch', 'Group1', 'Group2', 'Group3', 'Group4', '$mod', '+', <word>
ERROR: CONFIG: (in file /usr/share/regolith/common/config.d/30_navigation)
ERROR: CONFIG: Line  71: ## Navigate // Previous Workspace // <><Alt> ← ##
ERROR: CONFIG: Line  72: set_from_resource "" wm.binding.ws_prev2 Left
ERROR: CONFIG: Line  73: bindsym Mod4+Mod1+"" workspace prev
ERROR: CONFIG:                              ^^^^^^^^^^^^^^^^
ERROR: CONFIG: Line  74: 
ERROR: CONFIG: Line  75: ## Navigate // Previous Workspace on Output // <><Ctrl><Shift> Tab ##
ERROR: CONFIG: Expected one of these tokens: '--release', '--border', '--whole-window', '--exclude-titlebar', 'Mod1', 'Mod2', 'Mod3', 'Mod4', 'Mod5', 'Shift', 'Control', 'Ctrl', 'Mode_switch', 'Group1', 'Group2', 'Group3', 'Group4', '$mod', '+', <word>
ERROR: CONFIG: (in file /usr/share/regolith/common/config.d/30_navigation)
ERROR: CONFIG: Line  75: ## Navigate // Previous Workspace on Output // <><Ctrl><Shift> Tab ##
ERROR: CONFIG: Line  76: set_from_resource "" wm.binding.ws_prev_on_output Ctrl+Shift+Tab
ERROR: CONFIG: Line  77: bindsym Mod4+"" workspace prev_on_output
ERROR: CONFIG:                         ^^^^^^^^^^^^^^^^^^^^^^^^^^
ERROR: CONFIG: Line  78: 
ERROR: CONFIG: Line  79: ## Navigate // Previous Workspace on Output // <><Ctrl> h ##
ERROR: CONFIG: Expected one of these tokens: '--release', '--border', '--whole-window', '--exclude-titlebar', 'Mod1', 'Mod2', 'Mod3', 'Mod4', 'Mod5', 'Shift', 'Control', 'Ctrl', 'Mode_switch', 'Group1', 'Group2', 'Group3', 'Group4', '$mod', '+', <word>
ERROR: CONFIG: (in file /usr/share/regolith/common/config.d/30_navigation)
ERROR: CONFIG: Line  79: ## Navigate // Previous Workspace on Output // <><Ctrl> h ##
ERROR: CONFIG: Line  80: set_from_resource "" wm.binding.ws_prev_on_output2 Ctrl+h
ERROR: CONFIG: Line  81: bindsym Mod4+"" workspace prev_on_output
ERROR: CONFIG:                         ^^^^^^^^^^^^^^^^^^^^^^^^^^
ERROR: CONFIG: Line  82: 
ERROR: CONFIG: Line  83: ## Navigate // Scratchpad // <><Ctrl> a ##
ERROR: FYI: You are using i3 version 4.22 (2023-01-02)
ERROR: FYI: You are using i3 version 4.22 (2023-01-02)
ERROR: Received ConfigureNotify for unknown window 0x02600000
ERROR: Received ConfigureNotify for unknown window 0x02600000
ERROR: Received ConfigureNotify for unknown window 0x02600000
ERROR: Received ConfigureNotify for unknown window 0x02600008
ERROR: Received ExposeEvent for unknown window 0x02600008
ERROR: Received ConfigureNotify for unknown window 0x02600008
ERROR: Received ConfigureNotify for unknown window 0x0260000b
ERROR: Received ExposeEvent for unknown window 0x0260000b
ERROR: Received ConfigureNotify for unknown window 0x0260000b

IanEdington commented 6 months ago

btw, I just commented out those lines in the system file for now so I'm not blocked by this

kgilmer commented 6 months ago

Hi @IanEdington , hmm perhaps an older version of a package wasn't fully removed before an update was applied. Looking for what packages are providing the conflicting info, on my 3.1 machine I see:

$ dpkg -S 30_navigation
regolith-wm-navigation: /usr/share/regolith/common/config.d/30_navigation

Do you get this as well or something else?

IanEdington commented 6 months ago

Yes I got the same thing. Would it be helpful to have the list of regolith packages installed?

apt list --installed | grep "^regolith" | pbcopy

regolith-avizo/unknown,now 0.1.3-1regolith-jammy all [installed,automatic]
regolith-compositor-picom-glx/unknown,now 1.3.0-1regolith-jammy amd64 [installed,automatic]
regolith-control-center/unknown,now 1.41.18-1regolith-jammy amd64 [installed,automatic]
regolith-default-settings/unknown,now 2.0.4-1regolith-jammy amd64 [installed,automatic]
regolith-desktop/unknown,now 4.7.2-1regolith-jammy amd64 [installed]
regolith-displayd/unknown,now 0.2.5-1regolith-jammy amd64 [installed,automatic]
regolith-ftue/unknown,now 2.2.0-1regolith-jammy amd64 [installed,automatic]
regolith-i3-compositor/unknown,now 4.4.3-1regolith-jammy amd64 [installed,automatic]
regolith-i3-default-style/unknown,now 4.4.3-1regolith-jammy amd64 [installed,automatic]
regolith-i3-i3xrocks/unknown,now 4.4.3-1regolith-jammy amd64 [installed,automatic]
regolith-i3-ilia/unknown,now 4.4.3-1regolith-jammy amd64 [installed,automatic]
regolith-i3-root-config/unknown,now 4.4.3-1regolith-jammy amd64 [installed,automatic]
regolith-i3-session/unknown,now 4.4.3-1regolith-jammy amd64 [installed,automatic]
regolith-i3-unclutter/unknown,now 4.4.3-1regolith-jammy amd64 [installed,automatic]
regolith-i3xrocks-config/unknown,now 5.5.1-1regolith-jammy amd64 [installed,automatic]
regolith-inputd/unknown,now 0.2.3-1regolith-jammy amd64 [installed,automatic]
regolith-look-default-loader/unknown,now 0.8.2-1regolith-jammy amd64 [installed]
regolith-look-default/unknown,now 0.8.2-1regolith-jammy amd64 [installed]
regolith-look-i3-default/unknown,now 0.9.0-1regolith-jammy amd64 [installed]
regolith-look-solarized-dark/unknown,now 0.9.0-1regolith-jammy amd64 [installed]
regolith-powerd/unknown,now 0.2.0-1regolith-jammy amd64 [installed,automatic]
regolith-rofication/now 1.5.0-1regolith-lunar amd64 [installed,local]
regolith-session-common/unknown,now 1.0.5-1regolith-jammy amd64 [installed,automatic]
regolith-session-flashback-ext/unknown,now 1.0.5-1regolith-jammy amd64 [installed,automatic]
regolith-session-flashback/unknown,now 1.0.5-1regolith-jammy amd64 [installed]
regolith-session-sway/unknown,now 1.0.5-1regolith-jammy amd64 [installed]
regolith-sway-audio-idle-inhibit/unknown,now 4.4.3-1regolith-jammy amd64 [installed,automatic]
regolith-sway-background/unknown,now 4.4.3-1regolith-jammy amd64 [installed,automatic]
regolith-sway-control-center-regolith/unknown,now 4.4.3-1regolith-jammy amd64 [installed,automatic]
regolith-sway-dbus-activation/unknown,now 4.4.3-1regolith-jammy amd64 [installed,automatic]
regolith-sway-default-style/unknown,now 4.4.3-1regolith-jammy amd64 [installed,automatic]
regolith-sway-gaps/unknown,now 4.4.3-1regolith-jammy amd64 [installed,automatic]
regolith-sway-gsd/unknown,now 4.4.3-1regolith-jammy amd64 [installed,automatic]
regolith-sway-gtklock/unknown,now 4.4.3-1regolith-jammy amd64 [installed,automatic]
regolith-sway-i3status-rs/unknown,now 4.4.3-1regolith-jammy amd64 [installed,automatic]
regolith-sway-ilia/unknown,now 4.4.3-1regolith-jammy amd64 [installed,automatic]
regolith-sway-media-keys/unknown,now 4.4.3-1regolith-jammy amd64 [installed,automatic]
regolith-sway-polkit/unknown,now 4.4.3-1regolith-jammy amd64 [installed,automatic]
regolith-sway-root-config/unknown,now 4.4.3-1regolith-jammy amd64 [installed,automatic]
regolith-sway-screensharing/unknown,now 4.4.3-1regolith-jammy amd64 [installed,automatic]
regolith-sway-session/unknown,now 4.4.3-1regolith-jammy amd64 [installed,automatic]
regolith-sway-unclutter/unknown,now 4.4.3-1regolith-jammy amd64 [installed,automatic]
regolith-unclutter-xfixes/unknown,now 1.5-2-1regolith-jammy amd64 [installed,automatic]
regolith-wm-base-launchers/unknown,now 4.4.3-1regolith-jammy amd64 [installed,automatic]
regolith-wm-config/unknown,now 4.4.3-1regolith-jammy amd64 [installed,automatic]
regolith-wm-ftue/unknown,now 4.4.3-1regolith-jammy amd64 [installed,automatic]
regolith-wm-navigation/unknown,now 4.4.3-1regolith-jammy amd64 [installed,automatic]
regolith-wm-networkmanager/unknown,now 4.4.3-1regolith-jammy amd64 [installed,automatic]
regolith-wm-resize/unknown,now 4.4.3-1regolith-jammy amd64 [installed,automatic]
regolith-wm-rofication-ilia/unknown,now 4.4.3-1regolith-jammy amd64 [installed,automatic]
regolith-wm-swap-focus/unknown,now 4.4.3-1regolith-jammy amd64 [installed,automatic]
regolith-wm-workspace-config/unknown,now 4.4.3-1regolith-jammy amd64 [installed,automatic]

kgilmer commented 6 months ago

I took a closer look at the errors and realized what I thought your problem was isn't the case. It seems that the wm (are you running i3 or sway here?) is failing to parse that config partial. Can you tell me what versions of i3-wm and sway-regolith you have installed?

IanEdington commented 6 months ago

Thanks Ken!

I'm using i3 currently, but installed sway after the 3.1 upgrade. The errors are happening on both sway and i3. Although sway only reports the first line.

I hadn't thought of it before but that is something that changed along with the upgrade is installing regolith-session-sway. Do you want me to try uninstalling and seeing if the issue persists? My suspicion is that it shouldn't affect it.

Can you tell me what versions of i3-wm and sway-regolith you have installed?
i3-wm/now 4.22-1-1regolith-lunar amd64 [installed,local]
sway-regolith/unknown,now 1.7-6-1regolith-jammy amd64 [installed,automatic]

kgilmer commented 6 months ago

Got it, thanks for the additional details @IanEdington . In looking closer at the error messages, I notice that the i3 config files appear to be altered from how their installed. Here is an example. I assume you made some changes for remapping super or something to that effect. I would guess that the local edits are involved in the error messages, only because I've never seen these errors on installs in the past.

To proceed I suggest:

back up any files you have edited for your reference
re-install the package regolith-wm-config (sudo apt install --reinstall regolith-wm-config)
verify that the config files are restored to original version
log back into session

I would expect the errors to go away after that. LMK if it's not the case.

IanEdington commented 6 months ago

:grimacing: I hope that's not the case... I'll let you know :sweat:

IanEdington commented 5 months ago

I made a copy of the file in question to see if there's any change. I also removed my on configs from .config. I re-installed regolith-wm-config, then regolith-wm-navigation, then all the packages from the 4.4.3-1regolith-jammy repository using apt list --installed | grep regolith-jammy. At each point I checked for changes against 30_navigation and didn't see any change.

I am still getting the error, but no worries I've got a workaround. I'm happy to close this or leave it open to see if anyone else has a similar issue. Thanks for all the help!

IanEdington commented 5 months ago

I found the issue. I had a ~/.XResources that I forgot about and was defining wm.binding.ws_next: "" :disappointed:. I think the interpretation of "" must have changed which broke the configs.

Thanks again for your help!

regolith-linux / regolith-desktop

common 30_navigation config file throws errors after upgrade from 3.0 to 3.1 #997