search

regolith-linux / regolith-i3-config

Configuration and Xresource definitions for i3wm
21 stars 13 forks source link

smart_gaps cannot be disabled via Xresources #4

Open jjsearle opened 2 years ago

jjsearle commented 2 years ago

With the version of i3-gaps that ships with Regolith there is currently no way to disable smart_gaps without editing the partials to comment out the smart_gaps line. This is because the option does not accept 'falsey' values.

i3-gaps upstream has a accepted an PR that allows smart_gaps to be disabled via Xresources. Would you consider pulling this change into i3-gaps-wm ?

https://github.com/Airblader/i3/pull/434

I logged it on this project because you can't create issues on https://github.com/regolith-linux/i3-gaps-wm

kgilmer commented 2 years ago

Sounds good. There are patch updates for both i3 and i3-gaps. I'll roll them into a 2.1 beta, maybe later in the week.

eldenpark commented 1 year ago

Checking in to see if this is going to be treated. off should be available as an option as an example.

kgilmer commented 1 year ago

Hi @eldenpark , I've just rebased on i3/i3-gaps 4.21 which will contain the fix as part of Regolith 2.2.