search

regolith-linux / regolith-look-extra

Additional Looks for the Regolith Desktop
5 stars 12 forks source link

Cleanup deprecated picom options #11

Closed mfisher87 closed 1 year ago

mfisher87 commented 1 year ago

Cleanup deprecated picom options found in any looks.

With Regolith 2.2 I've been getting these in my logs using the nord look:

[ 12/23/2022 08:17:56.919 parse_config_libconfig WARN ] The refresh-rate option has been deprecated. Please remove it from your configuration file. If you encounter any problems without this feature, please feel free to open a bug report
[ 12/23/2022 08:17:56.919 parse_config_libconfig WARN ] The sw-opti option has been deprecated. Please remove it from your configuration file. If you encounter any problems without this feature, please feel free to open a bug report

My picom version is showing as:

$ picom --version
vgit-d4e24

Same change as https://github.com/regolith-linux/regolith-compositor-picom-glx/pull/6

kgilmer commented 1 year ago

Looks good to me and thanks for the contribution @mfisher87 . Before merging, can you briefly describe how you tested this change?

mfisher87 commented 1 year ago

I didn't know how to do much other than this very simple smoke test: I killed picom with pkill -f picom and then reinitialized it with the config file in my local copy of the repo picom --config /path/to/picom.conf. Prior to the change, the deprecation warnings reproduced. After the change, the deprecation warnings were not printed. I have been using the altered config for a day now and have noticed no "smoke" :)