regolith-linux / regolith-st

Suckless simple terminal (st) for Regolith Linux
6 stars 2 forks source link

Color scheme conflict #1

Closed ghost closed 5 years ago

ghost commented 5 years ago

The color scheme of the terminal makes it impossible to see certain text. For example, using neovim I'm editing a .vimrc file and some text colors match the background.

Screenshot from 2019-05-02 22-35-43

Here is the same file after I've dragged the mouse across it to select all the text, revealing text that had the same color as the background.

Screenshot from 2019-05-02 22-36-34

Notice lines 3, 4, and 8-14.

What would be the best course of action to correct this? Is this an issue with the st color theme, or perhaps and issue with the neovim syntax highlighting theme?

kgilmer commented 5 years ago

Does the same issue occur in light mode? (Toggle w F6)

On Thu, May 2, 2019, 7:40 PM Matt Reyer notifications@github.com wrote:

The color scheme of the terminal makes it impossible to see certain text. For example, using neovim I'm editing a .vimrc file and some text colors match the background.

[image: Screenshot from 2019-05-02 22-35-43] https://user-images.githubusercontent.com/270504/57117550-e3d5bb80-6d2a-11e9-9d86-9cf19832dea6.png

Here is the same file after I've dragged the mouse across it to select all the text, revealing text that had the same color as the background.

[image: Screenshot from 2019-05-02 22-36-34] https://user-images.githubusercontent.com/270504/57117573-1da6c200-6d2b-11e9-8698-c183e98c75f2.png

Notice lines 3, 4, and 8-14.

What would be the best course of action to correct this? Is this an issue with the st color theme, or perhaps and issue with the neovim syntax highlighting theme?

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/regolith-linux/regolith-st/issues/1, or mute the thread https://github.com/notifications/unsubscribe-auth/AAAMEEZW53ZIMOPOY77TMHTPTOQ2LANCNFSM4HKPYVZA .

kgilmer commented 5 years ago

To answer your question, I have not seen this issue myself. I use vim, but do not have any customization. This is where the solarized colors are defined for st: https://github.com/regolith-linux/regolith-st/blob/master/debian/patches/st-solarized-both-20190128-3be4cf1.diff

I am guessing that your vimrc uses similar colors and there is some text color that is too close to the background color of st...

ghost commented 5 years ago

Yep.

Screenshot from 2019-05-02 23-32-13

Screenshot from 2019-05-02 23-31-34

ghost commented 5 years ago

To clarify, this is all happening with a vanilla install of everything. Same results even without that minimal config you see in that screenshot. I haven't customized colors of anything myself. I'm new to vim so I'm not sure where the appropriate place to mess with colors is (terminal vs. vim itself).

kgilmer commented 5 years ago

Oh I see. I just installed neovim and see the same thing you do. Then I compiled st without any customization and my bashrc looks fine in neovim, so it's def something with the patches applied to st. I played around with the TERM variable but no luck. I suggest for now either using regular vim (2:8.0.1453-1ubuntu1) (install w/ sudo apt install vim) or perhaps use another terminal with neovim.

kgilmer commented 5 years ago

After some more searching I found that the Solarized patch that is in regolith-st recommends changing the colors for vim (I'm guessing neovim?):

https://st.suckless.org/patches/solarized/ https://bbs.archlinux.org/viewtopic.php?id=164108

Would love to know if this fixes your issue w/ neovim!

ghost commented 5 years ago

Installing this solarized theme did the trick! Maybe mentioning this issue in some documentation would help someone in the future.

https://github.com/altercation/solarized/tree/master/vim-colors-solarized

kgilmer commented 5 years ago

Great to hear and thanks for following up @winduptoy . I've added a README and referenced this issue: https://github.com/regolith-linux/regolith-st/tree/master

ghost commented 5 years ago

@kgilmer I think you've been hacked dude ☝️

kgilmer commented 5 years ago

Thanks @winduptoy , yep seems so. Hopefully changing all my passwords is enough. :worried: