search

regolith-linux / regolith-styles

A convention for organizing Xresource-based theme data.
GNU General Public License v3.0
57 stars 21 forks source link

Pop!_OS Style #26

Open adityamwagh opened 4 years ago

adityamwagh commented 4 years ago

I have created a Pop!_OS style for regolith.

I would like to add it here.

adityamwagh commented 4 years ago

I have forked it at https://github.com/ad1tyawagh/regolith-styles. and changed the colors in color and rofi.rasi to match the Pop!_OS GTK theme.

Since I am using Pop!_OS, I have access to the Pop terminal theme. So we can get it from there.

If anything else needs to be done, let me know.

kgilmer commented 4 years ago

Awesome, that's a great idea @ad1tyawagh ! There are a number of people that use Regolith on Pop!_OS, so I'm sure this will be a welcome addition. I'm a bit backed up on packaging work, let me get back to you in a bit! :smile:

kgilmer commented 4 years ago

@ad1tyawagh you can create a PR with your changes so we can review them. Here is an example I just merged: https://github.com/regolith-linux/regolith-styles/pull/25

adityamwagh commented 4 years ago

Okay! But it will take some time I think.

I am having some trouble porting the theme. I need to change colors to match the desktop perfectly.

About color palette

Also, why did you guys use base03, base02, ..., green as the color palette? Is there a very important reason behind that selection?

It's kind of difficult to port themes that way.

I think we should use color0, color1, ..., color15 as that makes it easy to port themes.

adityamwagh commented 4 years ago

I got it to show correct colors finally.

Also, there seems to be an issue with GNOME terminal color schemes in all styles. The cursor foreground color defaults to red.

kgilmer commented 4 years ago

The original key names for the colors came from the Solarized color palette definition, which was the original look of Regolith (before this was configurable) Yes you are right, it would be better to clean that up. It requires some big refactoring to all the looks, and is tedious. No one has picked it up as a task at this point.

Regarding the red cursor in gnome terminal....not sure what you mean. Can you provide a screenshot?

adityamwagh commented 4 years ago

I would love to fix key names.

How do I proceed with that?

From what I know, I would have to change the colors and other values in the files: gnome, i3-wm, i3xrocks, rofi and st-term.

Let me know if there are any other changes to be made, I will make a pull request after knowing exactly what all values are to be changed.

We can push this in the next release, or if I finish it sooner, we can change all the styles to match the new key names.

kgilmer commented 3 years ago

Hi @ad1tyawagh , sorry for the long delay. I'm starting to look into big changes to looks to simlify them and make it easier to create new ones. My thoughts are here if you're still interested.

I am actively experimenting with rethinking how Xresources are used to express UI configuration in Regolith. I can update you when I think I have something worth reviewing, LMK.

adityamwagh commented 3 years ago

Sure. Using the base16 color palette is a good idea. And the package organization changes are much appreciated.