search

regolith-linux / regolith-styles

A convention for organizing Xresource-based theme data.
GNU General Public License v3.0
56 stars 21 forks source link

Fix on background file path #39

Closed rcmschiavi closed 3 years ago

rcmschiavi commented 3 years ago

I installed all the themes on my machine and got "triggered" when the pop-os' default wallpaper was the same as the regolith one, then configuring the theme specs I found the problem, a small mistake on the file path at the theme file. I read the issues #26 and #25 and decided to contribute to the community work. Thx, guys.

kgilmer commented 3 years ago

Hi @rcmschiavi , nice, thanks for the PR! Hmm, I know this used to work. Perhaps this is a newer version of pop-os, and the background file path/image has changed? @ad1tyawagh any thoughts here?

adityamwagh commented 3 years ago

Actually I don't have Pop OS on my system. Will have to check using a VM. Wallpapers were bundled into the "pop-wallpapers" package last time I saw.

On Sat, Feb 27, 2021, 9:19 AM Ken Gilmer notifications@github.com wrote:

Hi @rcmschiavi https://github.com/rcmschiavi , nice, thanks for the PR! Hmm, I know this used to work. Perhaps this is a newer version of pop-os, and the background file path/image has changed? @ad1tyawagh https://github.com/ad1tyawagh any thoughts here?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/regolith-linux/regolith-styles/pull/39#issuecomment-786998478, or unsubscribe https://github.com/notifications/unsubscribe-auth/AGFAN7HZSVRQ3FNCZVLSXKTTBBTTPANCNFSM4YI3ZJRQ .

kgilmer commented 3 years ago

Thanks @ad1tyawagh but please don't bother w/ an install. I think i found the package and according to the Makefile the images should go into the pop directory. @rcmschiavi do you have these files from the pop-wallpapers package or something else?

kgilmer commented 3 years ago

I ended up fixing this as part of the 1.6 release

adityamwagh commented 3 years ago

Ok, what's the file path now?

kgilmer commented 3 years ago

It's defined here: https://github.com/regolith-linux/regolith-styles/blob/master/debian/regolith-look-pop-os.install#L6

I renamed the fille (added 'regolith') to ensure it wouldn't conflict with any pop-os theme packages.