regolith-linux / remontoire

A keybinding viewer for i3 and other programs.
GNU General Public License v3.0
68 stars 8 forks source link

Remontoire overflows on smaller resolution #17

Open iamjameswalters opened 3 years ago

iamjameswalters commented 3 years ago

I've just installed Regolith via PPA (1.5.1) on Ubuntu MATE 20.04.1 on an old Toshiba Satellite A205-S5804. Opening Remontoire's larger sections, namely Modify and Navigate, causes it to overflow and does not fit on the screen. I had to configure window placement to north to be able to shut the sections, since the default placement (east) shifted the collapsible toggles off-screen. Resolution here is 1280x800.

kgilmer commented 3 years ago

Hi @iamjameswalters , yes in fact it overflows on 1080p as well depending on what sections are open. One solution would be that remontoire collapses other open sections in the case that the full size would exceed the vertical resolution of the display.

Something you could do w/out an update would be to pass a custom CSS file that uses a smaller font, or edit the i3 config file to remove or add more categories. I don't suggest staging a copy of the i3 config file due to the upgrade issues it will eventually cause you to deal with, but it's an option.

iamjameswalters commented 3 years ago

One solution would be that remontoire collapses other open sections in the case that the full size would exceed the vertical resolution of the display.

This would be an excellent default behavior, and it sounds like that would certainly improve 1080p use cases.

Something you could do w/out an update would be to pass a custom CSS file that uses a smaller font

I'll look into what I can do here (though on 1280x800, I think it will take more than font size adjustments to make this fit, I'll have to try tweaking padding etc. as well). A suggestion, however: could it perhaps detect the vertical resolution and create parallel columns to expand horizontally? This is the sort of responsive behavior I would naturally expect.

Or perhaps create an overlay that hovers on a hotkey press, similar to the way the Unity Cheatsheet worked:

image

wvansolk commented 3 years ago

Another workaround for this could be adding an option to set window-position to "northeast" for example, or any other corner of the display

harakka commented 3 years ago

Limiting the window height to max desktop height and making the content scrollable would also help.

kgilmer commented 3 years ago

I've implemented @harakka 's suggestion in https://github.com/regolith-linux/remontoire/commit/96090d53661ca1e8723bb4ed6282b61657d72479. I think this is the simplest/most-obvious solution to this problem, if possibly not the best.

This change can be tested by checking out locally and building, or by trying a Regolith 2.0 alpha build. Very much interested to hear if anyone has thoughts on this approach to the issue!

kgilmer commented 3 years ago

Leaving issue open for feedback of the fix, will close eventually.

iamjameswalters commented 2 years ago

Excellent news! I will try to find a time soon to grab the alpha and spin this up to give it a go, hope to report back here with my feedback.

pablomalo commented 2 years ago

Compiled and installed on my system, works great. Very helpful. Thanks!