Closed kgilmer closed 5 months ago
I'm going to rename the branch once everything's kosher
Tested in VM
We'd need to apply a patch to make context menu's work as well. I'll take that up.
We'd need to apply a patch to make context menu's work as well. I'll take that up.
Nice! Just curious, is this something I missed in the porting from 1.8 or new functionality?
This was present in 1.8๐
I tried to test build this but was unsuccessful in my mantic system. Can you run a build on noble if possible?
This was present in 1.8๐
Oh, I think I was looking through the 1.8 diffs and assumed it was upstream stuff that got refactored. Nice catch :)
I tried to test build this but was unsuccessful in my mantic system. Can you run a build on noble if possible?
Sure! build attempt: https://github.com/regolith-linux/voulage/actions/runs/8412133671
Assuming by "context menu" we're talking about the app indicator thing and that if I see network-manager
applet's menu that means we're GTG. LMK if I'm off @SoumyaRanjanPatnaik
Hmm, there seems to be a problem with the patch. dbusmenu
no longer seems to be in the source tree from upstream
for upstream/v1.9
branch. There are types in the patch that reference symbols there. Not sure how it's compling for you @SoumyaRanjanPatnaik but for me this produces the problem
$ git clone https://github.com/regolith-linux/sway-regolith.git
$ git checkout packaging/v1.9-regolith-wip2
$ debuild -sa -b
Actually, I was unable to build it as the version of wlroots required for 1.9 is not available on mantic. I rebased the patch on v1.9 and thought it would work out of the box.
I was able to get it building locally on my noble
env by adding dbusheader from the 1.8 branch. Build attempt: https://github.com/regolith-linux/voulage/actions/runs/8445622385
Great. Might have missed adding that file๐ .
regarding that last commit, is it still WIP or should I add it to series and release the change for testing @SoumyaRanjanPatnaik ?
You can add that. This should make it so the config file and session files don't get installed into the package.
Btw, can you describe how you test? Do you set up a vm for testing?
Btw, can you describe how you test? Do you set up a vm for testing?
The sane way of testing is to, yeah, run the target environment in a VM and apply the Regolith update on top. I have used several VM managers in the past with mixed results. I've found "Virtual Machine Manager" to be the least bad, but it certainly has some problems.
In addition to VM testing, once things are somewhat stable on the new release, but before we release, I typically upgrade one of my home machines to the target OS/version and run it for a few days as a sort of "ambient smoke test".
I have been thinking recently about building more infra for better e2e testing for Regolith. I've found it's possible to specify a virtual framebuffer device to a desktop session running in a container, and there is a python library that allows for "remote control" of that container, such that clicks, key presses, and screenshots can be used to instrument tests. I have not begun implementation yet.
Build attempt into unstable
: https://github.com/regolith-linux/voulage/actions/runs/8548106813
Did this work?? Or we still get conflicts and sway session files?
Looking through branches tags in the unstable package model, came upon this PR :grinning: Yes, I believe it worked. Merging for beta release.
(I mistakenly merged this into upstream-1.9
. Renamed that branch to packaging/v1.9-regolith
)
This is sway 1.9 with Regolith changes encapsulated within
/debian
(NOTE the diff against upstream).Files:
sample build: https://github.com/regolith-linux/voulage/actions/runs/8290758402
sway-regolith is available for testing in
unstable
onnoble
.