regorxxx / Playlist-Tools-SMP

A collection of Spider Monkey tools for foobar2000: from removing duplicates, to dynamic queries or "spotify-like" playlist creation.
https://regorxxx.github.io/foobar2000-SMP.github.io/scripts/playlist-tools-smp/
GNU Affero General Public License v3.0
41 stars 6 forks source link

Playlist with ampersands not showing in playlist items #3

Closed stephen147 closed 3 years ago

stephen147 commented 3 years ago

I have a playlist named LISTEN & RATE.

It's displaying as:

image

regorxxx commented 3 years ago

Can you point me to the place where you are seeing that? Menus?

stephen147 commented 3 years ago

Here's where it is:

image

regorxxx commented 3 years ago

Nevermind, found the problem. & chars must be doubled to work as intended. Try it by yourself renaming your playlist with double &, and it should appear once on the menu.

Instead of editing Playlist Tools, I have edited the Menu Framework to replace by default all '&' with double &&. So it will work by default with arbitrary user input and I will not have to care anymore about it when writing new code. (in fact I didn't used that char on purpose on menus before).

regorxxx commented 3 years ago

By the way, the problem on my side is (was) & not showing at all. In your case & makes next char to be underscored, which is a behavior of text drawing but not menus. Check if my proposed workaround works (just test it and revert the change later), if it does, next release will fix it for you. Otherwise that would be a bug at other place (or SMP).

stephen147 commented 3 years ago

Doubling them up only resulted in the playlist name in fb having 2 ampersands which is to be expected but it did work to display correctly in your menus which means it can be fixed :)

image

regorxxx commented 3 years ago

Great. Thanks. Will be fixed on next release then, will take some days since I'm fully working on integration with the online controller (foo http_control) and some major changes for SMP main menus configuration which should allow foobar to be a direct replacement of other music servers too.

Btw, and not related in any way to that... is it comfortable to work with so many loaded playlists at the same time? Find in/Remove from/Send To/Go to playlist commands and too many playlists usability