search

regosen / get_cover_art

Batch cover art downloader and embedder for audio files
MIT License
69 stars 8 forks source link

Enhancement: option to download even if already embedded #3

Closed pidiggy closed 3 years ago

pidiggy commented 3 years ago

The Synology Audio Station requires jpg file in the same folder as album (not embedded in mp3 file).

Appears that if CoverFinder.scan_file finds artwork embedded in the mp3 file, it skips the download even with --test option is set.

Perhaps it could download the album cover art when a new "album_art" option is set true even if there is art-work embedded in the file.

regosen commented 3 years ago

I like this idea, I'll try adding a "force" option, will update you when it's live. Would it be okay if the "force" option replaced existing embedded artwork (as opposed to adding additional embedded art to the mp3 file)?

regosen commented 3 years ago

This should be fixed as well now- if you run with --force at the commandline (or set force to True for CoverFinder()), then it will allow downloading/embedding regardless of existing embedded artwork.

pidiggy commented 3 years ago

Ok thanks I will try it this weekend and give feedback.

regosen commented 3 years ago

Hi, can I close this issue? I got confirmation from another user that force is working, but I wanted to check with you as well.

tylerk86 commented 3 years ago

Most definitely! Thanks again and Happy New Year’s!

Tyler Kemp tylerkemp@icloud.com On Dec 31, 2020, 20:26 -0500, Rego Sen notifications@github.com, wrote:

Hi, can I close this issue? I got confirmation from another user that force is working, but I wanted to check with you as well. — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub, or unsubscribe.