search

regosen / get_cover_art

Batch cover art downloader and embedder for audio files
MIT License
76 stars 7 forks source link

Delete _cover_art folder when done #30

Closed julianfairfax closed 2 years ago

julianfairfax commented 2 years ago

It would be nice if this tool deleted the folder it creates when the command specified is done running

regosen commented 2 years ago

This is a good idea, though I would want it to be opt-in. I'm thinking of what to call the option, do you have any suggestions?

julianfairfax commented 2 years ago

--no-cache? or maybe --clear-cache to clear it?

regosen commented 2 years ago

I kinda like that, though when I see a "cache" option I usually expect it to clear cache before running the tool, not after. So I went with --cleanup instead, because that infers a post-cleanup to me.

I just posted a new version with this option (1.6.2), please let me know if it doesn't work as expected!

julianfairfax commented 2 years ago

It does, but if it skips the files it still creates the folder and doesn't clean it up afterwards. This should be changed to clean up in all cases.

regosen commented 2 years ago

Ah, good point. Ok, I just posted a new version (1.6.3).

julianfairfax commented 2 years ago

Works