search

regro / cf-scripts

Flagship repo for cf-regro-autotick-bot
Other
51 stars 74 forks source link

beta version slipped through #1198

Open beckermr opened 4 years ago

beckermr commented 4 years ago

This version was not caught by our filters.

8.1.0.beta.snapshot.33_h7f4941

cc @ocefpaf

ocefpaf commented 4 years ago

That one as beta, snapshot, and a hash! It was hidden in plain sight :stuck_out_tongue_winking_eye:

CJ-Wright commented 4 years ago

They've been building from betas for a while. see: https://github.com/conda-forge/esmf-feedstock/commit/4a2de7c540d795da673c0cb9f36eda44c30d36b9 and https://github.com/conda-forge/esmf-feedstock/commit/6ac747eb68ef61dbb07d50ec4541ad40fa72729b

The bot incremented the last value as it is supposed to and found a valid version. I'm not certain we want the bot to adjudicate these kinds of things, if the version string is particularly oddly formed we might still want the bot to make PRs.

I am reasonably confident that if they had stayed on a more standard versioning scheme (semver, calver, etc.) that the bot would not have offered up a beta release.