search

regro / cf-scripts

Flagship repo for cf-regro-autotick-bot
Other
46 stars 70 forks source link

`vtk` update missing migrator #2805

Open jakirkham opened 1 week ago

jakirkham commented 1 week ago

A few weeks back vtk was updated to 9.3.0: https://github.com/conda-forge/vtk-feedstock/pull/328

However the bot did not open a migrator PR

So @minrk needed to open one manually: https://github.com/conda-forge/conda-forge-pinning-feedstock/pull/6046

Do we know why the bot missed adding this migrator for vtk version 9.3.0?

beckermr commented 1 week ago

We lost an opportunity to debug when the pr was opened manually. Maybe I can cook up a test, but it will be a bit.

jakirkham commented 1 week ago

Ah ok. Sorry still catching up a bit

Maybe we can keep an eye on this for the next vtk update

jakirkham commented 4 days ago

Looks like another debugging window is opening with vtk version 9.3.1

xref: https://github.com/conda-forge/vtk-feedstock/pull/330

minrk commented 4 days ago

I'll make sure to not do the manual migrator this time.

minrk commented 2 days ago

I think the rerender error in the 9.3.1 PR probably points to the culprit, a recursion error in hash_dependencies:

File "/opt/conda/lib/python3.11/site-packages/conda_build/metadata.py", line 1787, in hash_dependencies
    hashing_dependencies = self.get_hash_contents()
                           ^^^^^^^^^^^^^^^^^^^^^^^^
  File "/opt/conda/lib/python3.11/site-packages/conda_build/metadata.py", line 1734, in get_hash_contents
    dependencies = set(self.get_used_vars())
                       ^^^^^^^^^^^^^^^^^^^^
  File "/opt/conda/lib/python3.11/site-packages/conda_build/metadata.py", line 2869, in get_used_vars
    script_reqs = self._get_used_vars_output_script()
                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/opt/conda/lib/python3.11/site-packages/conda_build/metadata.py", line 2988, in _get_used_vars_output_script
    self.get_rendered_output(self.name(), permit_undefined_jinja=True) or {}
    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/opt/conda/lib/python3.11/site-packages/conda_build/metadata.py", line 2821, in get_rendered_output
    for output_ in self.get_rendered_outputs_section(
                   ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/opt/conda/lib/python3.11/site-packages/conda_build/metadata.py", line 2803, in get_rendered_outputs_section
    self._get_contents(
  File "/opt/conda/lib/python3.11/site-packages/conda_build/metadata.py", line 2054, in _get_contents
    env.globals.update(get_dict(m=self, skip_build_id=skip_build_id))
                       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/opt/conda/lib/python3.11/site-packages/conda_build/environ.py", line 370, in get_dict
    d.update(meta_vars(m, skip_build_id=skip_build_id))
             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/opt/conda/lib/python3.11/site-packages/conda_build/environ.py", line 597, in meta_vars
    d["PKG_HASH"] = meta.hash_dependencies()
                    ^^^^^^^^^^^^^^^^^^^^^^^^
  File "/opt/conda/lib/python3.11/site-packages/conda_build/metadata.py", line 1787, in hash_dependencies
    hashing_dependencies = self.get_hash_contents()
jakirkham commented 2 days ago

Thanks Min! 🙏

Interesting, thought we had fixed a lot of the re-rendering issues recently ( https://github.com/conda-forge/vtk-feedstock/pull/327 ). Though I guess new issues cropped up?