regro / cf-scripts

Flagship repo for cf-regro-autotick-bot
Other
49 stars 74 forks source link

Build graph from `recipe.yaml` #2851

Closed Hofer-Julian closed 2 months ago

Hofer-Julian commented 2 months ago

Tests:

codecov[bot] commented 2 months ago

Codecov Report

Attention: Patch coverage is 82.65306% with 17 lines in your changes missing coverage. Please review.

Project coverage is 76.96%. Comparing base (0642d39) to head (82639a6).

Files Patch % Lines
conda_forge_tick/utils.py 77.77% 12 Missing :warning:
conda_forge_tick/feedstock_parser.py 82.60% 4 Missing :warning:
conda_forge_tick/update_sources.py 75.00% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #2851 +/- ## ========================================== + Coverage 76.92% 76.96% +0.04% ========================================== Files 111 112 +1 Lines 11870 11943 +73 ========================================== + Hits 9131 9192 +61 - Misses 2739 2751 +12 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

jezdez commented 2 months ago

This PR title seems to bury the led that this is adding rattler-build to conda-forge?

beckermr commented 2 months ago

Well "adding to conda-forge" is a bit misleading since full support in all of our tools will take a long, long time.

It is true that with this PR, we will be using rattler-build as the current parser for the new format when building the bot's graph.

However, that is a design choice we can change later should other parsers come along.

Hofer-Julian commented 2 months ago

Thanks for the review comments during the process @beckermr, they were very helpful!

This is the current status of the PR: