Closed Hofer-Julian closed 2 months ago
Attention: Patch coverage is 82.65306%
with 17 lines
in your changes missing coverage. Please review.
Project coverage is 76.96%. Comparing base (
0642d39
) to head (82639a6
).
Files | Patch % | Lines |
---|---|---|
conda_forge_tick/utils.py | 77.77% | 12 Missing :warning: |
conda_forge_tick/feedstock_parser.py | 82.60% | 4 Missing :warning: |
conda_forge_tick/update_sources.py | 75.00% | 1 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
This PR title seems to bury the led that this is adding rattler-build to conda-forge?
Well "adding to conda-forge" is a bit misleading since full support in all of our tools will take a long, long time.
It is true that with this PR, we will be using rattler-build as the current parser for the new format when building the bot's graph.
However, that is a design choice we can change later should other parsers come along.
Thanks for the review comments during the process @beckermr, they were very helpful!
This is the current status of the PR:
rattler-build
is used to render the recipe, if it exists with a failure an exception is thrown, please let me know if you prefer a different behaviortest
field, according to @wolfv the two recipe formats differ too much here for that to make sense.ci_support files
should be accounted for, I haven't added tests for that one thoughfor_pinning
is not supported yet, and will be implemented in a follow-uppathlib
for functions that I've touched, please let me know if you want me to refrain from these drive-by improvements in the future
Tests:
parse-feedstock
recipe.yaml
is rendered and parsed correctly