regro / cf-scripts

Flagship repo for cf-regro-autotick-bot
Other
49 stars 74 forks source link

model check should not run on PRs or pushes #2864

Closed ytausch closed 2 months ago

ytausch commented 2 months ago

The model check should only be run periodically and on request, not on pushes to master or PRs.

xref https://github.com/regro/cf-scripts/issues/2244#issuecomment-2200064651

For debugging, it is still possible to run this on request or locally.

Unfortunately, there is no other good way to remove confusion about the red crosses: https://github.com/orgs/community/discussions/15452

codecov[bot] commented 2 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 76.92%. Comparing base (1bb7b43) to head (0890d70).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #2864 +/- ## ======================================= Coverage 76.92% 76.92% ======================================= Files 111 111 Lines 11870 11870 ======================================= Hits 9131 9131 Misses 2739 2739 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

ytausch commented 2 months ago

Sorry for disabling auto-merging, I will post something in one sec

ytausch commented 2 months ago

What do you think about 0d9c72c? It still runs the model tests for PRs but never causes a failed check for PRs which is more intuitive I think because a failed model test does not indicate a PR is bad.

beckermr commented 2 months ago

Ok I'm happy with this. We can use GitHub workflow commands to add warnings to ci jobs. I'll likely enable this for my own use.