search

regro / cf-scripts

Flagship repo for cf-regro-autotick-bot
Other
51 stars 74 forks source link

Docker Image includes `.git` folder #2876

Open ytausch opened 2 months ago

ytausch commented 2 months ago

Our Docker image currently contains a .git folder, which is not needed in the image. Probably there are even more things towards a minimal image, which will also be faster to build.

beckermr commented 2 months ago

How much space is the .git folder? My guess is that there are bigger things to do than that?

ytausch commented 1 month ago

Yes, probably. I just wanted to point out the git folder because it came to my attention as something that should clearly not be in the image. The git folder also contains a git token provided by GitHub which, I confirmed, has no security relevance for us.

jakirkham commented 1 month ago

Should be easy to add to .dockerignore