Open jakirkham opened 1 month ago
cc @beckermr
yes we can add a mini-migrator but we'll need to figure out a decent way to understand what we need to add - it is not clear to me when we need setuptools-only vs both setuptools+wheel.
To the extent that Python packages declare these dependencies in their pyproject.toml
's build-system.requires
, grayskull
can pick them up and add them
Is this something that depfinder
checks?
depfinder
only detects imports and so would miss this in some cases.
Can you please share some examples? Identifying the edge cases will help us come up with a better solution
Oh right sorry. Here are the ones I am thinking of. None of them mean we cannot do this, but it will require thought+code.
depfinder
won't check anything since it only looks at python importsAs an interesting example
lda
gets flagged as needing setuptools
: https://github.com/conda-forge/lda-feedstock/pull/12
AFAICT it is only used in lda
's cibuildwheels
tests
Even more interestingly, setuptools is already in host in that recipe. :/
Ahhhh. The bot flagging that is not related to depfinder or grayskull but is because it detected that package in host.
In preparation for changes in
pip
's packaging as discussed in issue ( https://github.com/conda-forge/pip-feedstock/issues/124 ), it would be good if we could detect the usage ofsetuptools
and/orwheel
in Python packages and add them torequirements/host
if they are needed