search

regro / cf-scripts

Flagship repo for cf-regro-autotick-bot
Other
53 stars 74 forks source link

Check for Prerelease on GitHub #324

Open jakirkham opened 6 years ago

jakirkham commented 6 years ago

It's possible to mark a release as a Prerelease on GitHub. Doing this is independent of noting RC in the version or similar. This is something that conda does regularly and some other packages do as well. Would be nice if the bot could check for the Prerelease indicator and handle it the same way as we do other RCs.

ref: https://github.com/conda-forge/tmux-feedstock/pull/10#issuecomment-413924879

CJ-Wright commented 6 years ago

This might be a bit difficult since most of the time RawURL triggers before GitHub so we won't have access to the full github json.

ihnorton commented 5 years ago

The github releases.atom feed doesn't distinguish draft releases, unfortunately. AFAICT the bot is currently using RSS...

It looks like there are already a lot of issues with rate-limiting, so it might be problematic to use the GitHub API directly? Perhaps continue using RSS for routine checks, but then filter for pre-release status using the GH API when a potential new release is detected.

ytausch commented 3 months ago

Using the new GithubReleases version provider exclusively is a good workaround (fix?) for this since the /releases/latest endpoint of GitHub ignores prereleases.

Try it out: https://github.com/microsoft/terminal/releases/latest

I will add documentation to the conda-forge wiki about this. After that, I think this issue can be closed.

ytausch commented 3 months ago

Documentation is here: https://github.com/conda-forge/conda-smithy/pull/1998

Exemplary usage: https://github.com/conda-forge/windows-terminal-feedstock/pull/5

mfisher87 commented 3 months ago

@ytausch I attempted this, but I still got a PR from a pre-release. Should I open a new issue, or should it be tracked by this one?

https://github.com/conda-forge/quarto-feedstock/pull/54 https://github.com/conda-forge/quarto-feedstock/blob/367d3113dcea2e1652a41841ab98c7332ee295c0/conda-forge.yml#L17 https://github.com/quarto-dev/quarto-cli/releases/tag/v1.6.3

ytausch commented 3 months ago

@mfisher87 I highly suspect this was just some flaky behavior of the bot because the old pre-release version was still cached in the bot's metadata.

1.6.4, which is also a pre-release, was skipped by the bot correctly.

If the issue comes up again, feel free to just reply in this issue.

ytausch commented 3 months ago

Quarto 1.5.56 should be PRed by the bot after this metadata patch is merged - this is a bug on the bot's side.

mfisher87 commented 3 months ago

Amazing, thank you @ytausch :heart_eyes: