regro / cf-scripts

Flagship repo for cf-regro-autotick-bot
Other
47 stars 72 forks source link

Readding repos to migrations #518

Open jakirkham opened 5 years ago

jakirkham commented 5 years ago

For a variety of reasons a users may choose to close a migration PR even though it is not yet complete. Currently we assume this means the feedstock has already been migrated (even if that is not the case). How can we handle this more gracefully? Is there or could there be a way for users to readd their feedstock to the active migration? If so, what would this look like? How can we communicate to users the intended workflow?

scopatz commented 5 years ago

Probably have a GitHub label, like bot-delay or bot-skip that the user adds to that repo, similar to bot-rerun

CJ-Wright commented 4 years ago

I don't know what the workflow is here. Why would one close a bot migration PR? How long would bot-delay delay for? If it got a PR that means it should be ready for the migration.

jakirkham commented 4 years ago

Usually people are trying to get the CI to restart. Just the other day, I had such a problem with a PR where the CI became unresponsive so had to close-and-reopen a bot PR.

CJ-Wright commented 4 years ago

Ah, closing and reopening most likely is ok. We can add a timeout for the bot that requires that the PR be closed for 10 mins or more before writing the migration off. So long as the PRs don't stay closed.

jakirkham commented 4 years ago

That sounds like a good fix. 🙂