search

regro / cf-scripts

Flagship repo for cf-regro-autotick-bot
Other
48 stars 72 forks source link

Migration for noarch packages with pyXX-egg.info #797

Open isuruf opened 4 years ago

isuruf commented 4 years ago

See https://github.com/conda/conda/issues/7693

If they are rebuilt with pip>9, then the correct directory structure will be created.

isuruf commented 4 years ago

If there are packages using --no-cache-dir even with pip>9, this issue will be there. So, --no-cache-dir also needs to be removed.

beckermr commented 4 years ago

We have a piggyback for python build strings. Does this not cover it?

I guess you want something explicit (like a non-piggyback migration)?

isuruf commented 4 years ago

We should look at packages built with older pip even without --no-cache-dir. Those wouldn't be in the migrator for python build strings. I also think we should have a non-piggyback migrator to fix this.

beckermr commented 4 years ago

@regro/auto-tick @CJ-Wright where do we / can we pull in info from the about section of the built packages? This is where we can find what version of pip was used.

CJ-Wright commented 4 years ago

Libcfgraph

isuruf commented 4 years ago

You can also use libcfgraph to just check that there is a pyXX-egg.info directory instead of checking for the version of pip used.

beckermr commented 4 years ago

Right ok. I want to make sure that data is not already stored in the graph nodes in the migrator code (which are per feedstock and not output). I guess the answer there is no?

CJ-Wright commented 4 years ago

Yeah, the mapping between packages and feedstocks can be a bit rough