search

regro / conda-metachannel

like a conda-metapackage but for channels!
MIT License
69 stars 4 forks source link

actually expire graph #15

Closed scopatz closed 5 years ago

scopatz commented 5 years ago

The TTLCache only seems to remove expired entries if there is a mutating event (set / del) and not on access (get), see https://cachetools.readthedocs.io/en/latest/index.html?highlight=ttlcache#cachetools.TTLCache.

This means that if the cache size is not reached than old graphs can stick around indefinitely. I believe that this explains #14 and some of the related issues. Here is a fix to manually remove expired elements, if needed.

scopatz commented 5 years ago

pinging this

CJ-Wright commented 5 years ago

LGTM but you might wait for @mariusvniekerk (or not, up to you)

scopatz commented 5 years ago

I think it might be nice to get @mariusvniekerk's eyes on this :)

scopatz commented 5 years ago

OK, I think this is ready for another look

scopatz commented 5 years ago

ready for another look

mariusvniekerk commented 5 years ago

LGTM

scopatz commented 5 years ago

Ok, gonna push a release