search

regro / regolith

Research Group Content Managment System
http://regro.github.io/regolith-docs/
Other
15 stars 71 forks source link

Change docs dir to doc dir #1127

Closed stevenhua0320 closed 4 months ago

stevenhua0320 commented 4 months ago

Merge these doc files

codecov[bot] commented 4 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Please upload report for BASE (cookie@e253621). Learn more about missing BASE report.

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/regro/regolith/pull/1127/graphs/tree.svg?width=650&height=150&src=pr&token=YOWfAqEPVS&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=regro)](https://app.codecov.io/gh/regro/regolith/pull/1127?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=regro) ```diff @@ Coverage Diff @@ ## cookie #1127 +/- ## ========================================= Coverage ? 69.07% ========================================= Files ? 96 Lines ? 9997 Branches ? 0 ========================================= Hits ? 6905 Misses ? 3092 Partials ? 0 ``` ------ [Continue to review full report in Codecov by Sentry](https://app.codecov.io/gh/regro/regolith/pull/1127?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=regro). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=regro) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://app.codecov.io/gh/regro/regolith/pull/1127?dropdown=coverage&src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=regro). Last update [e253621...794d73f](https://app.codecov.io/gh/regro/regolith/pull/1127?dropdown=coverage&src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=regro). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=regro).
sbillinge commented 4 months ago

@stevenhua0320 sorry about this, but please can you redo this on a new PR without the reverted commits. WHen you make a commit and then revert it, it stores in the git database the full commit and then the un-commit, i.e., It stores all the changes to all the files, and then it stores the unchanges. This is ok when the commit is small (just a few lines changed) but when the commit is big, like moving hundreds of files, it is not a good idea.

The work you did in the last two commits is fine and I can merge that.

stevenhua0320 commented 4 months ago

@stevenhua0320 sorry about this, but please can you redo this on a new PR without the reverted commits. WHen you make a commit and then revert it, it stores in the git database the full commit and then the un-commit, i.e., It stores all the changes to all the files, and then it stores the unchanges. This is ok when the commit is small (just a few lines changed) but when the commit is big, like moving hundreds of files, it is not a good idea.

The work you did in the last two commits is fine and I can merge that.

OK, I would redo these right now. I would close this PR.