Closed sbillinge closed 3 years ago
no need to set up travis.....just make the change (unpin the version) and make a PR and travis will run on the PR. See if it passes!
On Thu, Jul 15, 2021 at 11:24 AM Connor J. Bracy @.***> wrote:
Looking into this, using the current master branch revision I created a fresh conda environment using Python 3.9.6, then ran:
conda install -c conda-forge --file requirements/run.txt conda install -c conda-forge --file requirements/test.txt pip install -e . python run_tests.py
which (locally) produced the same results as when I run the tests using the same master revision in my usual regolith_env (which uses Python 3.7.10) so I'm guessing this means it should be fine to move TravisCI to working with Python 3.9 but I don't currently have TravisCI setup so I figure I'd provide this information here and wait to see what you think @sbillinge https://github.com/sbillinge before I waste time setting up TravisCI for what will ultimately be either a 1 or 3 line change in the regolith/.travis.yml file
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/regro/regolith/issues/635#issuecomment-880789148, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABAOWUP6P2P2H3JAWGZ4HRLTX34R5ANCNFSM4S5RUEVA .
-- Simon Billinge Professor, Columbia University Physicist, Brookhaven National Laboratory
Looking into this, using the current
master
branch revision I created a fresh conda environment using Python 3.9.6, then ran:which (locally) produced the same results as when I run the tests using the same
master
revision in my usualregolith_env
(which uses Python 3.7.10) so I'm guessing this means it should be fine to move TravisCI to working with Python 3.9 but I don't currently have TravisCI setup so I figure I'd provide this information here and wait to see what you think @sbillinge before I waste time setting up TravisCI for what will ultimately be either a 1 or 3 line change in theregolith/.travis.yml
file