search

regro / rever

Releaser of Versions
https://regro.github.io/rever-docs/
BSD 3-Clause "New" or "Revised" License
74 stars 34 forks source link

BUG: updated github authentication was ignored by program #108

Open sbillinge opened 6 years ago

sbillinge commented 6 years ago

behavior was as follows: 1) tried to run rever for a new release 2) fixed multiple errors in various places and kept rerunning.... 3) finally got the github push which failed 4) realized that in the config the push authentication was given as ssh but my account is set up using https 5) changed the authentication command in setup.py to the https command 6) retried rever but it kept looking for the ssh authentication for some reason

@CJ-Wright is looking into this, but I am reporting for completeness

CJ-Wright commented 6 years ago

@sbillinge Thank you very much for reporting!

CJ-Wright commented 6 years ago

This is a backwards compatibility issue. When Tag and PushTag were the same activity the name of the remote in the environment was TAG_REMOTE (as it is in the xpdsim rever.xsh). However, when the two were separated that variable was changed to PUSH_TAG_REMOTE. In the absence of a PUSH_TAG_REMOTE target rever tried the next best thing, which was to build the remote from the GITHUB_ORG and GITHUB_REPO, creating an ssh target.

I think the best solution here is to honor TAG_REMOTE (since we aren't using it for anything else) and print a dep warning to tell users to move to PUSH_TAG_REMOTE. (And of course fix this in xpdSim for our next release)