search

regro / rever

Releaser of Versions
https://regro.github.io/rever-docs/
BSD 3-Clause "New" or "Revised" License
74 stars 34 forks source link

comp ids #125

Closed scopatz closed 6 years ago

scopatz commented 6 years ago

I stupidly named two of my computers with the same hostname, which only drew out this issue.

CJ-Wright commented 6 years ago

otherwise lgtm

scopatz commented 6 years ago

looks like it passes

CJ-Wright commented 6 years ago

to be fair I don't know if we test that chunk of the code

scopatz commented 6 years ago

This chunk of code is hard to test because it involves making and destroying github tokens. So either the test code would need a user's password or we'd need need a separate test account with a semi-secret password. Also, all of that is presumably done in the tests of github3.py.

scopatz commented 6 years ago

thanks for the merge!

CJ-Wright commented 6 years ago

Yea, I mean my point was more that I didn't expect the PR to fail. Sure!