search

regro / rever

Releaser of Versions
https://regro.github.io/rever-docs/
BSD 3-Clause "New" or "Revised" License
75 stars 34 forks source link

GitHub Release Assets #131

Closed scopatz closed 6 years ago

scopatz commented 6 years ago

CC @CJ-Wright @justcalamari

scopatz commented 6 years ago

Note that this gets us most of the way to #130 and there is an example with it working at https://github.com/scopatz/rever-dummy/releases

CJ-Wright commented 6 years ago

Should we offer the option to remove the asset after it is uploaded? It might be odd to be carrying around a generated asset in the source.

scopatz commented 6 years ago

Ok, I have added a git archive default, which does solve #130.

Should we offer the option to remove the asset after it is uploaded? It might be odd to be carrying around a generated asset in the source.

The best practice is probably for these assets to be created in an ignored place, such as $REVER_DIR, or for python, the dist/ dir

CJ-Wright commented 6 years ago

LGTM