Closed CJ-Wright closed 5 years ago
Thanks for putting this in @CJ-Wright! I think that both of these need to have check methods and specify which CLI tools they use. You can check out some of the other activities that use checks for examples
Is there anything in particular you want to "specify which CLI tools they use" beyond the check stuff.
Is there anything in particular you want to "specify which CLI tools they use" beyond the check stuff.
Nope just the check stuff! Also, is there a reasonable way we can test this?
Not sure about testing, maybe google will let us to hello world apps? (eg make a test/example which uses their tutorial + rever)
Yeah, if there is an anonymous hello world that doesn't need credentials, that's be great! Otherwise, maybe you can alias gcloud
and kubctrl
to echo
, like we do in some of the other tests.
do you have an example of echo
in the tests?
Looks like it is a fixture, defined here: https://github.com/regro/rever/blob/master/tests/conftest.py#L37
used here: https://github.com/regro/rever/blob/master/tests/test_conda_forge_activity.py#L242
@scopatz any idea why there is a KeyError: 'Unknown environment variable: $LOGGER'
for the gcloud tests?
You are not using the gitrepo
fixture to set up a proper context
LGTM, anything else you want to change?
No I think this is good (we tested the app one today and it seemed to work properly). Do you want a squash? (I guess we should run a release and then change metachannel to use the new activity)
Squash is evil :)
Thanks @CJ-Wright!
Thank you!
@scopatz