search

regro / rever

Releaser of Versions
https://regro.github.io/rever-docs/
BSD 3-Clause "New" or "Revised" License
75 stars 33 forks source link

Add repo name to archive #186

Closed msarahan closed 5 years ago

msarahan commented 5 years ago

The past several releases of conda-package handling show their version as "unknown" because versioneer didn't work when the extracted folder name was just "$version". I think I probably could fix versioneer with the setup.cfg parameters, but I also think adding the project name to the tarball is generally a good thing, as it makes it easier to look at stuff on disk. Plain version numbers are pretty inscrutable.

This also removes some conda update --update-deps --all calls, because those two are mutually exclusive (--all implies --update-deps). This broke in my testing of the other change because the docker image was rebuilt, and a newer conda version may have been brought in.

scopatz commented 5 years ago

Thanks @msarahan! Can you also change the conda-forge activity to look for the new filename: https://github.com/regro/rever/blob/master/rever/activities/conda_forge.xsh#L146

msarahan commented 5 years ago

I pushed one change: added --prefix. This means that the extracted folder name to be $repo-$version. Without this, the archives that got extracted still weren't working with versioneer, because their contents were extracted directly into the work dir.

msarahan commented 5 years ago

@scopatz done

scopatz commented 5 years ago

Thanks @msarahan - do you want me to cut a rever release for this?

msarahan commented 5 years ago

If you want. I'm happy to run on my dev branch, though, so don't worry too much about it.

scopatz commented 5 years ago

I think I'll try to cut a release, just so that rever can act as its own test case here.