regro / rever

Releaser of Versions
https://regro.github.io/rever-docs/
BSD 3-Clause "New" or "Revised" License
75 stars 33 forks source link

rever check stopped in bash #217

Closed anki-code closed 4 years ago

anki-code commented 4 years ago

Hi! This is my first try to use rever.

The rever.xsh file is in https://github.com/regro/rever/issues/216.

When I run rever check from bash it stops:

xonsh$ bash
bash$ cd ~/git/xontrib-prompt-bar
bash$ rever check
No checks needed for tag activity
All CLI and import requirements met for push_tag activity

[1]+  Stopped                 rever check

It looks like the same as https://github.com/xonsh/xonsh/issues/3555

What I'm doing wrong?

hadim commented 4 years ago

I observe the same issue. Sometimes it works sometimes it doesn't and I can't find the cause of it.

hadim commented 4 years ago

The issue only happen when executing rever from master (0.4.4). When installing from conda or git checkout 0.4.3 it works ok.

I am working on a PR to add an activity right now. I will have to make build it on top of 0.4.3 and not master.

I also had to fix xonsh to 0.9.18.

scopatz commented 4 years ago

Yeah, I have seen this issue too on mac. Rolling back to xonsh=0.9.18 rever=0.4.3 seems to fix it. I think the error is in xonsh, but if anyone can help figure out what the regression is that would be awesome!

scopatz commented 4 years ago

This does seem to be an issue running in Bash. I don't see this issue in xonsh, but I can reproduce it in Linux. So we know it is not some weird mac issue

hadim commented 4 years ago

My main station is Ubuntu 20.04 so I can confirm this issue also happens on Linux. And my shell is the regular bash shipped with Ubuntu.

scopatz commented 4 years ago

Minimal reproducible example at https://gitter.im/xonsh/xonsh?at=5f39d1745ccdf30c584ddd8b makes me think this is a pure xonsh issue

scopatz commented 4 years ago

Doing a git bisect, the problematic commit seems to be 921f284b22c30f78a33cdcad78d7bec99e18c744 in xonsh

scopatz commented 4 years ago

Nm, I just reran this with better repo cleaning and the bug seems to be in a8d4a57f01a25b1ce77f0a3adec1c0b11f49ad1a

scopatz commented 4 years ago

@anki-code @hadim - #226 should address this if either of you would like to test it out

hadim commented 4 years ago

Will try it soon.