regro / rever

Releaser of Versions
https://regro.github.io/rever-docs/
BSD 3-Clause "New" or "Revised" License
74 stars 33 forks source link

Remove xonda from the conda support #227

Closed asmeurer closed 3 years ago

asmeurer commented 3 years ago

xonda is no longer needed for conda activate to work in xonsh.

Also move the conda commands in the context manager inside of a try/finally.

asmeurer commented 3 years ago

With this I get this error

CommandNotFoundError: Your shell has not been properly configured to use 'conda activate'.
To initialize your shell, run

    $ conda init <SHELL_NAME>

Currently supported shells are:
  - bash
  - fish
  - tcsh
  - xonsh
  - zsh
  - powershell

See 'conda init --help' for more information and options.

IMPORTANT: You may need to close and restart your shell after running 'conda init'.
asmeurer commented 3 years ago

I think we would need to run whatever conda init xonsh does (but without actually modifying .xonshrc).

asmeurer commented 3 years ago

Should be something like execx("$(conda shell.xonsh hook)") (except that doesn't work).

scopatz commented 3 years ago

Some additional fixes in #228