search

regro / rever

Releaser of Versions
https://regro.github.io/rever-docs/
BSD 3-Clause "New" or "Revised" License
75 stars 34 forks source link

GHRELEASE_TARGET #238

Closed scopatz closed 3 years ago

scopatz commented 3 years ago

Potential fix for #237

scopatz commented 3 years ago

CC @CJ-Wright - whenever you get a chance, could review this please?

asmeurer commented 3 years ago

Shouldn't it use the default branch from the repo by default? That requires the API to get, but that shouldn't be an issue for an action that is about uploading a release.

scopatz commented 3 years ago

Yeah, that is better, @asmeurer

scopatz commented 3 years ago

Updated!

hadim commented 3 years ago

The same kind of fix could also be applied to the forge activity.

hadim commented 3 years ago

@rjkoch do you think that could be merged too?

rjkoch commented 3 years ago

LGTM, bit new to this myself, @CJ-Wright what do you think? could be part of the next release...

CJ-Wright commented 3 years ago

LGTM, I didn't realize GH had a default branch concept.

I am making this comment solely in my personal capacity and am not conveying any rights to any intellectual property of any third parties.

@rjkoch please feel free to merge!

CJ-Wright commented 3 years ago

(Note you may need to walk back some of the partially finished release so these changes can be let in) I am making this comment solely in my personal capacity and am not conveying any rights to any intellectual property of any third parties.