search

regro / rever

Releaser of Versions
https://regro.github.io/rever-docs/
BSD 3-Clause "New" or "Revised" License
75 stars 34 forks source link

Fixed broken github login behavior #243

Closed rjkoch closed 3 years ago

rjkoch commented 3 years ago

This should fix the broken login behavior. I don't personally use regro so I don't have any projects I can test it on, but I was able to successfully authorize and login using the new code.

CJ-Wright commented 3 years ago

Can you open a PR for the CI things as well?

(sorry to go all "give a mouse a cookie on you")

I am making this comment solely in my personal capacity and am not conveying any rights to any intellectual property of any third parties.

rjkoch commented 3 years ago

The problem for travis appears to be the Xonsh Env https://github.com/regro/rever/blob/c7052b99a336f463c9a124ddcccf468517af3885/docs/conf.py#L25 https://github.com/regro/rever/blob/c7052b99a336f463c9a124ddcccf468517af3885/docs/conf.py#L266

It's get_docs method is returning an object https://github.com/regro/rever/blob/c7052b99a336f463c9a124ddcccf468517af3885/docs/conf.py#L291

This object doesn't have the attribute doc_configurable https://github.com/regro/rever/blob/c7052b99a336f463c9a124ddcccf468517af3885/docs/conf.py#L293

CJ-Wright commented 3 years ago

This looks great and is passing CI (or at least the one that I'm worried about). If you copied code from somewhere else please include that code's license in the body of the module you copied it to, this way we can respect the license terms (which usually include a clause saying the license must be shipped with any copy of the code).

I am making this comment solely in my personal capacity and am not conveying any rights to any intellectual property of any third parties.

rjkoch commented 3 years ago

Thanks Chris! I've added the license from doctr and removed unnecessary references in comments.