search

regro / rever

Releaser of Versions
https://regro.github.io/rever-docs/
BSD 3-Clause "New" or "Revised" License
75 stars 34 forks source link

Allow for authors with no email address in git log #252

Open takluyver opened 3 years ago

takluyver commented 3 years ago

It's not common, but it does happen. I'm not going to force people to reveal their email address if they don't want to.

Closes #251.

takluyver commented 3 years ago

The CI failure looks unrelated, but it's not clear to me what's going on.

______________________ xonsh test: test_run_in_conda_env _______________________
xonsh execution failed
  File "/home/circleci/project/tests/test_conda.xsh", line 11, in test_run_in_conda_env
    assert 'rever-env' in $(conda info -e)
AssertionError:
takluyver commented 3 years ago

Anyone? @rjkoch, it looks like you touched this repository most recently.

Sorry to pester, but we've currently got a PR on h5py that we can't merge without either fixing this or figuring out some workaround.

rjkoch commented 3 years ago

@takluyver No need to apologize, I'm looking into this now, it wasn't on my radar at all until you tagged me.

I'd like to get the CI working before merging.

Does test_conda.xsh run successfully for you locally?

rjkoch commented 3 years ago

@takluyver Something upstream has broken the test, the last merged commit (which passed when it merged) is no longer passing. will need a couple days to dig into this. Sorry to hold things up.

takluyver commented 3 years ago

No worries. We've actually decided to stop using the 'authors' activity - beyond this specific issue, it has been tricky for new contributors to correctly add themselves to .authors.yml - so this won't be holding us up any longer.

test_conda.xsh passes when I run it locally. I haven't updated conda recently - maybe the output of conda info has changed?

rjkoch commented 3 years ago

@takluyver I had similar issues with .authors.yml when working on rever myself.

I've looked into it and test_conda.xsh is set up to be skipped locally unless you modify environment variables, such that it only runs in CI. I'm going to sniff out the upstream issue and get this merged in any case, because the commits look good to me and are a reasonable modification.

takluyver commented 3 years ago

Yup, I was setting CI=1 to avoid skipping the test. :slightly_smiling_face: