search

regro / rever

Releaser of Versions
https://regro.github.io/rever-docs/
BSD 3-Clause "New" or "Revised" License
74 stars 33 forks source link

Tarballs are not uploaded to PyPI #254

Closed saraedum closed 1 year ago

saraedum commented 2 years ago

It seems that rever is not uploading .tar.gz source distributions to PyPI when configured with

$PYPI_BUILD_COMMANDS = ['sdist', 'bdist_wheel']

I have this setting for two projects, and in both I need to manually twine upload the tarballs to PyPI.

Am I doing something wrong in these two rever scripts: sage-flatsurf and svgdigitizer?

For most users a wheel is perfectly fine. However, without the tarball, conda-forge does not pick up the new version automatically if its configured to download the tarball from PyPI.

saraedum commented 2 years ago

The problem is that we append --dist-dir=… to the build command, i.e., we invoke

python setup.py sdist bdist_wheel --dist-dir=…

However, --dist-dir then only affects the bdist_wheel command but not sdist. A correct invocation would be

python setup.py sdist --dist-dir=… bdist_wheel --dist-dir=…
hadim commented 2 years ago

I am also having the same issue.

So far the only solution is to remove the pypi activity from the rever config and use python setup.py sdist && twine upload dist/* instead.