regro / rever

Releaser of Versions
https://regro.github.io/rever-docs/
BSD 3-Clause "New" or "Revised" License
75 stars 34 forks source link

Create staged-recipe PR #97

Open CJ-Wright opened 6 years ago

CJ-Wright commented 6 years ago

If we are going to do conda-forge PRs maybe we should have something that builds the initial PR into staged-recipes.

Pieces

  1. Initial provisioning with version/sha (after PushTag so we can pull it from GH?)
  2. Read requirements from requirements/build and requirements/run.
  3. Read test deps from requirements/test

Questions

  1. Do we want to push after creating the recipe?
  2. Do we want to run the tests in the recipe?
  3. Do we want to pull the maintainers/licence info/other info from somewhere?
scopatz commented 6 years ago

Thanks for bringing this up @CJ-Wright! This is a setup task in my mind, for sure.

In terms of getting the requirements, I don't like the idea do pulling from a named file. We already have a variable called $DOCKER_CONDA_DEPS . Maybe we should have one or a few called $CONDA_BUILD_DEPS, $CONDA_DEPS and $CONDA_TEST_DEPS. If folks want to read these from a requirments file, that is fine.

Do we want to push after creating the recipe?

Yes, otherwise what is the point. We probably should fork staged recipes if it doesn't exist.

Do we want to run the tests in the recipe?

Yes

Do we want to pull the maintainers/licence info/other info from somewhere?

Yes.

This feature will have a lot of parametrizations associated with it.

CJ-Wright commented 6 years ago

Will we have a version/tag/etc up during setup? Do we need these for a staged-recipes PR?

scopatz commented 6 years ago

Unfortunately right now you can't assume a version number for setup, but this is information you need for staged recipes

CJ-Wright commented 6 years ago

I guess we could a conditional inside the conda_forge activity that searches for a feedstock. If none exists then we go and make a PR into staged otherwise continue as usual.

scopatz commented 6 years ago

Hmm I am -1 on that behaviour. Getting something through staged-recipes is a once-in-a-project activity. Therefore, it is a setup task, not something that should happen if it doesn't exist.

CJ-Wright commented 6 years ago

That's fair