search

regulaforensics / react-native-document-reader

React-Native Framework for reading and validation of identification documents
19 stars 10 forks source link

Podspec file should be constant #17

Open johanblumenberg opened 1 year ago

johanblumenberg commented 1 year ago

Description

See this line: https://github.com/regulaforensics/react-native-document-reader/blob/dc7a708281f04d1dbaa99b7960a223fa968eafa8/RNDocumentReaderApi.podspec#L14

It refers to __dir__, which means that the podspec which is generated on each developers machine will look different, since it contains the full path to the package inside node_modules. This means that each developer will generate a different Podfile.lock file, since the hash of the Pod will contain the local folder.

Solution

Most other react native packages seem to put the github URL as the source:

  s.source       = { :git => "https://github.com/regulaforensics/react-native-document-reader" }
johanblumenberg commented 1 year ago

This is a problem also for RNDocumentReaderCore and RNFaceApi