Closed mfebrizio closed 4 months ago
I reviewed all the commits and it looks good to me. Thanks, Mark!
I reviewed all the commits and it looks good to me. Thanks, Mark!
Thanks to you, @yqz5514 ! You did the work haha, I just unintentionally made it more complicated.
@yqz5514 -- sorry but I messed up the PR as I was trying to integrate your changes with recent updates to the main branch. So I ended up creating a new PR that integrated your code with those other updates. Let me know whether this looks like it accounts for what you worked on.
I tested the code for each chart and they don't throw the warnings anymore, as well as reflect recent changes.