search

regzo2 / BinaryParameterTool

Create animations for Binary Parameters for VRCFaceTracking
16 stars 4 forks source link

Improve "Create" button behavior #10

Open kusomaigo opened 1 year ago

kusomaigo commented 1 year ago

Various fixes to the behavior of the "Create" button, including fix for the "create parameter" toggle similar to Jerry's PR #9. This is a more comprehensive rewrite of that segment of code in BinaryParameterWindow.cs. Tool behavior should now be more logical across tool setting permutations.

Also contains code not in the git branch but in the latest unity package release that causes a Collection was modified enumeration operation may not execute error. Code has since been fixed and renamed, but is currently not utilized.

kusomaigo commented 1 year ago

I was notified of the bug in the latest pre-release unity package from https://discord.com/channels/849300336128032789/922962294210711594/1061127730550292560 and ended up making more changes 🤷