search

rehabstudio / fbmessenger

A python library to communicate with the Facebook Messenger API's
Other
114 stars 50 forks source link

Add support for `notification_type` #21

Closed danfairs closed 6 years ago

danfairs commented 6 years ago

This adds support for notification_type (https://developers.facebook.com/docs/messenger-platform/reference/send-api/). It controls how the user is notified about an outgoing message.

I've added this as an argument to the send call, as it feels more like metadata about the send than a property of the message itself. It's backward compatible, so I've just incremented the minor version.

I also made some minor test cleanups, using a fixture instead of repeated creation of a messenger client instance.

Let me know if you need any changes!

coveralls commented 6 years ago

Coverage Status

Coverage remained the same at 100.0% when pulling 4e6afd3875ff2b6b5d8afed8dcb47b96f595c9ed on danfairs:notification-types into 7cd02a21baa17b978042e79e3f374f094cc7b5b9 on rehabstudio:master.

rickydunlop commented 6 years ago

Thanks for this @danfairs, just released 5.1.0 to pypi too.

danfairs commented 6 years ago

Thanks @rickydunlop!