search

rehamaltamimi / gwtwiki

Automatically exported from code.google.com/p/gwtwiki
0 stars 0 forks source link

Performance issue : toLowerCase on parseURIScheme #23

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago 
What steps will reproduce the problem?

Using the WikiXMLParser class.

What is the expected output? What do you see instead?

Performance could be improved without calling toLowerCase.

What version of the product are you using? On what operating system?

3.0.13

Please provide any additional information below.

I found that parsing was really slow, so I launched Yourkit profiler on my
program and discovered that almost 70% of time spent is spent in the
toLowerCase() method in WikipediaParser#parseURIScheme() method.

I guess this could be improved by adding both lowercase and uppercase
versions of URI schemes in the configuration instead of using toLowerCase.

Attached file is an export of the profiling session in HTML.

Original issue reported on code.google.com by cedric.c...@gmail.com on 23 Oct 2009 at 3:06

Attachments:

GoogleCodeExporter commented 8 years ago

Original comment by axelclk@gmail.com on 23 Oct 2009 at 3:16

GoogleCodeExporter commented 8 years ago 
Ok, I changed the coding to avoid the toLowerCase() call.
But I think it will probably perform only slightly better.
http://code.google.com/p/gwtwiki/source/detail?r=518

Original comment by axelclk@gmail.com on 23 Oct 2009 at 5:16

GoogleCodeExporter commented 8 years ago

Original comment by axelclk@gmail.com on 5 Jan 2010 at 7:24