rehamaltamimi / gwtwiki

Automatically exported from code.google.com/p/gwtwiki
0 stars 0 forks source link

"<pre>" tag with "name" attribute is not a good idea #43

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago
The generator creates

<pre name="code" class="javascript">

for every listing. That's invalid.

Original issue reported on code.google.com by ullenb...@gmail.com on 13 May 2010 at 9:29

GoogleCodeExporter commented 8 years ago

Original comment by axelclk@gmail.com on 14 May 2010 at 4:42

GoogleCodeExporter commented 8 years ago
Ok I'm deleting the "name" attribute.

In the IWikiModel#showSyntax() method you can decide, if the coding should be
highlighted or not.
If showSyntax() returns "true", should we use the same div and pre tags 
combination
as Wikipedia and if "false", we only use the pre tag with a class attribute and 
no
text highlighting (useful for JavaScript highlighters)?

<div dir="ltr" class="mw-geshi" style="text-align: left;">

<div class="javascript source-javascript" style="font-family:monospace;">
<pre class="de1">

...
</pre></div>
</div>

Original comment by axelclk@gmail.com on 14 May 2010 at 5:00

GoogleCodeExporter commented 8 years ago
Changed:
http://code.google.com/p/gwtwiki/source/detail?r=1322

Original comment by axelclk@gmail.com on 16 May 2010 at 12:11

GoogleCodeExporter commented 8 years ago

Original comment by axelclk@gmail.com on 27 May 2010 at 5:45

GoogleCodeExporter commented 8 years ago

Original comment by axelclk@gmail.com on 7 Jul 2010 at 5:24