rehamaltamimi / gwtwiki

Automatically exported from code.google.com/p/gwtwiki
0 stars 0 forks source link

Template parameter expansion with mixed named/unnamed parameters #56

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago
Found incorrect behavior when expanding mixed named/unnamed parameters.
For example, parsing '{{rellink|extraclasses=seealso|See also [[link]]}}' code 
gives parameter map of [extraclasses=seealso, 2=See also [[link]] ]
But the latter part must receive '1' as parameter name instead of 2.
This is stated in 
http://meta.wikimedia.org/wiki/Help:Template#Mix_of_named_and_unnamed_parameters

Quick fix attached. This breaks testTemplateCall2 and testTemplateCall3 tests, 
but it's ok, since the reference output isn't correct according mediawiki docs.

Original issue reported on code.google.com by kazenni...@gmail.com on 17 Nov 2010 at 9:24

Attachments:

GoogleCodeExporter commented 8 years ago
Thanks for the patch, I noticed this as well - works for me. :-)

Original comment by dfisla@gmail.com on 17 Nov 2010 at 11:53

GoogleCodeExporter commented 8 years ago
Thanks for the patch.

I've commited it here:
http://code.google.com/p/gwtwiki/source/detail?r=2759

Original comment by axelclk@gmail.com on 18 Nov 2010 at 5:55

GoogleCodeExporter commented 8 years ago

Original comment by axelclk@gmail.com on 18 Dec 2010 at 3:36