rehanguha / brisque

Blind/Referenceless Image Spatial QUality Evaluator (BRISQUE)
https://pypi.org/project/brisque/
Apache License 2.0
55 stars 8 forks source link

Adding Ndarray image as input #8

Closed Andrew-Ma-2001 closed 2 years ago

Andrew-Ma-2001 commented 2 years ago

Hi, wonderful job. I was wondering if adding an input of Ndarray image would be more useful in practice. I personally use brisque to read images from videos, so that in this way using Ndarray image as input seems more friendly to users. No worries, I already change the source code to achieve reading Ndarray, but I think for further improvement, maybe my suggestion could be helpful.

rehanguha commented 2 years ago

Hi @Andrew-Ma-2001 , Thank you for your feedback. I feel it will be a great addition... It will be great if you can push a quick PR and keep and argument to toggle the type. I feel it will be a great addition.

On Fri, 14 Oct, 2022, 21:31 Andrew-Ma-2001, @.***> wrote:

Hi, wonderful job. I was wondering if adding an input of Ndarray image would be more useful in practice. I personally use brisque to read images from videos, so that in this way using Ndarray image as input seems more friendly to users. No worries, I already change the source code to achieve reading Ndarray, but I think for further improvement, maybe my suggestion could be helpful.

— Reply to this email directly, view it on GitHub https://github.com/rehanguha/brisque/issues/8, or unsubscribe https://github.com/notifications/unsubscribe-auth/AD25YHUCGWQY6YRKNA7EXFTWDF7W3ANCNFSM6AAAAAARFL35W4 . You are receiving this because you are subscribed to this thread.Message ID: @.***>

Andrew-Ma-2001 commented 2 years ago

Sorry for the late response, I've add an pull request please check.